Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB3 model import: convert definition of nested properties #3811

Closed
2 tasks
bajtos opened this issue Sep 26, 2019 · 2 comments
Closed
2 tasks

LB3 model import: convert definition of nested properties #3811

bajtos opened this issue Sep 26, 2019 · 2 comments

Comments

@bajtos
Copy link
Member

bajtos commented Sep 26, 2019

The syntax used for property definitions is slightly different between LB3 and LB4. The initial implementation of the import command is converting only top-level properties. We should convert nested properties too, both in anonymous objects and arrays.

An example of a model with nested properties:

{
  "name": "Product",
  "properties": {
    "rating": {
      "average": "number",
      "totalVotes": "number",
    }
  }
}

Acceptance criteria

  • Implement the feature as described above, including automated tests
  • Update Importing-LB3-models.md, remove the relevant point from the list of known limitations
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Dec 25, 2020
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants