Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the @requestBody #3496

Closed
3 tasks
jannyHou opened this issue Aug 1, 2019 · 2 comments
Closed
3 tasks

Improve the @requestBody #3496

jannyHou opened this issue Aug 1, 2019 · 2 comments

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Aug 1, 2019

Suggestion

A follow-up story for #2654

Use Cases

Implement @requestBody(spec, model, schemaOptions) as the new requestBody decorator.

Examples

See the Create endpoint and Update endpoint.

Acceptance criteria

  • Modify the current @requestBody() according to the spike code, pass
    existing tests across all repos.
  • Add more unit tests to verify all the signatures.
  • Fix the type conflict detect, see test case 'catches type conflict', and
    discussion in
    comment
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Dec 25, 2020
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants