Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Unregister runtime artifacts for Controller class #3124

Closed
3 tasks
dhmlau opened this issue Jun 12, 2019 · 4 comments
Closed
3 tasks

Spike: Unregister runtime artifacts for Controller class #3124

dhmlau opened this issue Jun 12, 2019 · 4 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented Jun 12, 2019

Description / Steps to reproduce / Feature proposal

Originated from #2619

Please see @bajtos' comment: #2619 (comment) for details

Acceptance Criteria

  • When a controller + repo + model is unregistered, there must be no memory references remaining, so that V8 can release and collect the memory.
  • Test case: write a loop creating & unregistering model+repo+controller. The process should use relatively constant memory, the memory usage must not grow.
    • The test should not run it as part of npm test workflow

Timebox to 3 days

@bajtos
Copy link
Member

bajtos commented Jun 14, 2019

Test case: write a loop creating & unregistering model+repo+controller. The process should use relatively constant memory, the memory usage must not grow.

I am expecting that such test will require at least several seconds (if not minutes) to run. We should not run it as part of npm test workflow.

@bajtos bajtos added 2019Q4 and removed 2019Q3 labels Jun 25, 2019
@dhmlau dhmlau removed the 2019Q4 label Sep 12, 2019
@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Sep 7, 2020
@dhmlau dhmlau removed the stale label Sep 7, 2020
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Jul 14, 2021
@stale
Copy link

stale bot commented Aug 13, 2021

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants