Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasOne relation type to lb4 relation #2980

Closed
2 tasks
dhmlau opened this issue May 28, 2019 · 7 comments · Fixed by #4171
Closed
2 tasks

Add hasOne relation type to lb4 relation #2980

dhmlau opened this issue May 28, 2019 · 7 comments · Fixed by #4171
Assignees
@lokeshmohanty
Labels
CLI developer-experience Issues affecting ease of use and overall experience of LB users feature good first issue help wanted Relations Model relations (has many, etc.)

Comments

@dhmlau
Copy link
Member

dhmlau commented May 28, 2019 •
edited by agnes512
Loading

Description / Steps to reproduce / Feature proposal

Trying out the lb4 relation command from the master branch and realized that there are only 2 model relation types available for selection: belongsTo and hasMany.

We should add the hasOne relation type as one of the options as well.

Acceptance Criteria

  • when running lb4 relation command, there should be 3 options for relation types: belongsTo, hasMany and hasOne (should be added in this work item) ( should implement the "inclusion resolver" prompt too)
  • add related cli tests
@dhmlau dhmlau added needs grooming Relations Model relations (has many, etc.) 2019Q3 feature labels May 28, 2019
@dhmlau dhmlau mentioned this issue Sep 6, 2019
Closed
@dhmlau
Copy link
Member Author

dhmlau commented Sep 6, 2019

@lakinmohapatra, this is the same issue you've reported. Would you like to submit a PR? Thanks.

@lokeshmohanty
Copy link
Contributor

@dhmlau I would like to work on this. Can you assign this to me?

@dhmlau
Copy link
Member Author

dhmlau commented Oct 2, 2019

@lokesh1197, of course!

@dhmlau
Copy link
Member Author

dhmlau commented Nov 13, 2019

@lokesh1197, are you still interested in working on a PR for this? I think I haven't seen a related PR. Thanks.

@dhmlau dhmlau added 2020Q1 developer-experience Issues affecting ease of use and overall experience of LB users CLI labels Nov 13, 2019
@lokeshmohanty
Copy link
Contributor

@dhmlau I was working on it. But I got busy in another project so I had to stop. Currently the tests part is remaining. I will try to finish it within this week.

@dhmlau
Copy link
Member Author

dhmlau commented Nov 14, 2019

cool thanks!

This was referenced Nov 14, 2019
Merged
Closed
@lokeshmohanty lokeshmohanty mentioned this issue Nov 20, 2019
Merged
@dhmlau
Copy link
Member Author

dhmlau commented Nov 21, 2019

PR #4171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokeshmohanty lokeshmohanty

Labels
CLI developer-experience Issues affecting ease of use and overall experience of LB users feature good first issue help wanted Relations Model relations (has many, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): add hasOne relation type to lb4 relation lokeshmohanty/loopback-next
2 participants
@lokeshmohanty @dhmlau