Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the authentication action to be a common one. #2467

Closed
1 task
jannyHou opened this issue Feb 25, 2019 · 4 comments · Fixed by #2859
Closed
1 task

Refactor the authentication action to be a common one. #2467

jannyHou opened this issue Feb 25, 2019 · 4 comments · Fixed by #2859
Assignees

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Feb 25, 2019

Description

Refactor the authentication action to be a common one that could perform authenticate for both non-passport based strategies and passport based strategies.

Acceptance criteria

@bajtos
Copy link
Member

bajtos commented Mar 5, 2019

Isn't this a necessary part of #2466: Add abstraction for authentication strategy? I mean what is a new abstraction good for, when it's not used by the authentication action?

@jannyHou
Copy link
Contributor Author

I was trying to split the abstraction story into separate ones, honestly without working on the code I couldn't say for sure does the auth action have to be refactored together with the auth strategy interface 😞

@emonddr
Copy link
Contributor

emonddr commented Apr 18, 2019

May involve the work needed in #2311

@dhmlau
Copy link
Member

dhmlau commented May 13, 2019

@emonddr @jannyHou, now that PR #2688 has landed, is this task done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants