-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the authentication action to be a common one. #2467
Comments
Isn't this a necessary part of #2466: Add abstraction for authentication strategy? I mean what is a new abstraction good for, when it's not used by the authentication action? |
I was trying to split the abstraction story into separate ones, honestly without working on the code I couldn't say for sure does the auth action have to be refactored together with the auth strategy interface 😞 |
May involve the work needed in #2311 |
Description
Refactor the authentication action to be a common one that could perform
authenticate
for both non-passport based strategies and passport based strategies.Acceptance criteria
action
so that it could perform any strategy's authenticate method, not only passport based ones.AuthenticationStrategy
interface created in Add abstraction for authentication strategy #2466The text was updated successfully, but these errors were encountered: