Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Use express constructs / enable express shimming for Authentication #191

Closed
6 tasks
deepakrkris opened this issue Apr 21, 2017 · 3 comments · Fixed by #1326
Closed
6 tasks

Spike: Use express constructs / enable express shimming for Authentication #191

deepakrkris opened this issue Apr 21, 2017 · 3 comments · Fixed by #1326
Assignees
@deepakrkris
Labels
REST Issues related to @loopback/rest package and REST transport in general

Comments

@deepakrkris
Copy link
Contributor

deepakrkris commented Apr 21, 2017 •
edited
Loading

  • Use of passport-strategy's with dependence on Express request, response constructs
    Confirm:
    • request.session
    • response.json
    • response.send
    • response.type
  • Shim/inject express dependencies without using express request/response/middleware
@deepakrkris deepakrkris self-assigned this Apr 21, 2017
@superkhau
Copy link
Contributor

@deepakrkris I'm guessing this is already done as part of your work on the Auth package impl. Safe to close?

@bajtos
Copy link
Member

bajtos commented Jul 14, 2017

This may be required for #230 and/or #160.

@dhmlau dhmlau added the Core-GA label Sep 6, 2017
@bajtos bajtos added the p2 label Dec 15, 2017
@dhmlau dhmlau mentioned this issue Feb 15, 2018
Closed
11 tasks
@dhmlau dhmlau mentioned this issue Feb 22, 2018
Closed
@dhmlau dhmlau added DP3 and removed p2 labels Mar 27, 2018
@bajtos
Copy link
Member

bajtos commented May 15, 2018

We need to revisit the goal of this story, considering that we are going to use Express REquest/Response types internally soon.

@bajtos bajtos added the REST Issues related to @loopback/rest package and REST transport in general label May 16, 2018
@bajtos bajtos mentioned this issue May 16, 2018
Merged
7 tasks
@bajtos bajtos added the p1 label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakrkris deepakrkris

Labels
REST Issues related to @loopback/rest package and REST transport in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rest): use Express req/res types loopbackio/loopback-next
4 participants
@bajtos @superkhau @deepakrkris @dhmlau