Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Update generationStatus handling in ArtifactGenerator #1524

Closed
3 tasks
virkt25 opened this issue Jul 13, 2018 · 2 comments
Closed
3 tasks

[CLI] Update generationStatus handling in ArtifactGenerator #1524

virkt25 opened this issue Jul 13, 2018 · 2 comments

Comments

@virkt25
Copy link
Contributor

virkt25 commented Jul 13, 2018

Description / Steps to reproduce / Feature proposal

As per the comment here: #1487 (comment)

Ideally, I think we should generationStatus file by file now instead of a global flag. For example,
models/model-1.ts (success)
models/model-2.ts (skipped)

Current generationStatus check:

 let generationStatus = true;
    // Check all files being generated to ensure they succeeded
    Object.entries(this.conflicter.generationStatus).forEach(([key, val]) => {
      if (val === 'skip' || val === 'identical') generationStatus = false;
    });

Acceptance Criteria

  • Move generationStatus check in ArtifactGenerator out of end -- but after scaffold to handle multiple files.
  • Update the generationStatus to support handling of multiple files
  • Move the call to _updateIndexFiles from end to outside of end (before it but after generationStatus check (or maybe part of the same function))

Helpful Links

@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Oct 28, 2019
@stale
Copy link

stale bot commented Nov 27, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants