You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally, I think we should generationStatus file by file now instead of a global flag. For example,
models/model-1.ts (success)
models/model-2.ts (skipped)
Current generationStatus check:
let generationStatus = true;
// Check all files being generated to ensure they succeeded
Object.entries(this.conflicter.generationStatus).forEach(([key, val]) => {
if (val === 'skip' || val === 'identical') generationStatus = false;
});
Acceptance Criteria
Move generationStatus check in ArtifactGenerator out of end -- but after scaffold to handle multiple files.
Update the generationStatus to support handling of multiple files
Move the call to _updateIndexFiles from end to outside of end (before it but after generationStatus check (or maybe part of the same function))
This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.
Description / Steps to reproduce / Feature proposal
As per the comment here: #1487 (comment)
Current
generationStatus
check:Acceptance Criteria
end
-- but afterscaffold
to handle multiple files._updateIndexFiles
fromend
to outside ofend
(before it but after generationStatus check (or maybe part of the same function))Helpful Links
The text was updated successfully, but these errors were encountered: