Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relation] Supports HasOne relation #1422

Closed
8 tasks done
dhmlau opened this issue Jun 12, 2018 · 3 comments
Closed
8 tasks done

[Relation] Supports HasOne relation #1422

dhmlau opened this issue Jun 12, 2018 · 3 comments
Assignees
Labels
feature parity Juggler Relations Model relations (has many, etc.)

Comments

@dhmlau
Copy link
Member

dhmlau commented Jun 12, 2018

Description / Steps to reproduce / Feature proposal

Add support for HasOne relation between two models.

Acceptance Criteria

  • Update factory method to handle this relation
  • create interface for CRUD methods available for the relation. See this as an example.
    • create default class which implements the interface
  • Implement the hasOne decorator
    • model decorator: infers the metadata
  • create test cases
  • update docs
  • create a follow up issue to demonstrate using multiple relations in a new/existing example
@dhmlau dhmlau changed the title [Relation] Supports HasOne [Relation] Supports HasOne relation Jun 12, 2018
@dhmlau dhmlau added the Core-GA label Jun 12, 2018
@bajtos bajtos mentioned this issue Jun 21, 2018
12 tasks
@bajtos bajtos added the Juggler label Jun 25, 2018
@dhmlau dhmlau added the p1 label Jun 26, 2018
@bajtos bajtos added p2 and removed p1 labels Aug 28, 2018
@dhmlau dhmlau added post-GA and removed LB4 GA labels Sep 6, 2018
@dhmlau
Copy link
Member Author

dhmlau commented Oct 1, 2018

Cross posting in #1449 (comment) from @elv1s:

We have a requirement for hasOne in addition to hasMany and belongsTo

Currently hasOne is not part of our Q1 roadmap. So I have 2 questions:

  1. @elv1s, what is the timeline you're thinking in terms of having hasOne support?
  2. @strongloop/sq-lb-apex @raymondfeng @bajtos, after we have the 2 model relations, do you think it's a relatively small effort for us to get hasOne in?
    EDIT: I realized that we've estimated this task already. Given what we know now (esp when implementing BelongsTo, are we still good with this estimate?

@elv1s
Copy link
Contributor

elv1s commented Oct 3, 2018

We are developing a POC with LB3 right now. If we move to LB4 we would need hasOne relationships early 2019.

@b-admike
Copy link
Contributor

Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature parity Juggler Relations Model relations (has many, etc.)
Projects
None yet
Development

No branches or pull requests

4 participants