Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP endpoint factory #1331

Closed
bajtos opened this issue May 16, 2018 · 1 comment
Closed

HTTP endpoint factory #1331

bajtos opened this issue May 16, 2018 · 1 comment
Assignees
Labels
feature REST Issues related to @loopback/rest package and REST transport in general

Comments

@bajtos
Copy link
Member

bajtos commented May 16, 2018

Rework the way how an HTTP server is setup and configured for LoopBack applications (RestServer instances) following the approach outlined in #1082.

IMPORTANT

The spike was based on an assumption that we will support different frameworks (Express, Koa, etc.). Based on the spike outcome, we decided to go forward with a single framework and use Express request/response types everywhere. As a result, most of the spike code needs to be simplified by removing generic type arguments etc.

https://github.com/strongloop/loopback-next/blob/2bddc47ccda56a50c52a8a92facd87e3a3f4944d/packages/http-server/src/common.ts#L12-L48

https://github.com/strongloop/loopback-next/blob/2bddc47ccda56a50c52a8a92facd87e3a3f4944d/packages/http-server/src/common.ts#L116-L212

Acceptance criteria

  • There should be a new module for creating HTTP and HTTPS servers.
  • @loopback/rest should use this new module to start/stop the server
    - The module should support HTTP config only

Out of scope

The following features are out of scope, but please keep them in mind when designing the new module.

@bajtos bajtos added feature REST Issues related to @loopback/rest package and REST transport in general DP3 labels May 16, 2018
@hacksparrow hacksparrow self-assigned this May 17, 2018
@dhmlau dhmlau added this to the June Milestone milestone May 29, 2018
@dhmlau
Copy link
Member

dhmlau commented Jun 11, 2018

Closing this as PR #1369 has merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature REST Issues related to @loopback/rest package and REST transport in general
Projects
None yet
Development

No branches or pull requests

3 participants