Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Figure out the responsibility between express middleware and LB4 routing and sequencing #1291

Closed
1 task
hacksparrow opened this issue Apr 27, 2018 · 4 comments
Assignees
Labels
feature REST Issues related to @loopback/rest package and REST transport in general stale

Comments

@hacksparrow
Copy link
Contributor

hacksparrow commented Apr 27, 2018

Description / Steps to reproduce / Feature proposal

Mount LB4 apps (REST servers) as Express (and Express-compatible) middleware

Current Behavior

None

Expected Behavior

#1082 (comment)

Acceptance Criteria

LB4 apps should be mountable as Express or Express-compatible middleware.

timeboxed to 1 week

See Reporting Issues for more tips on writing good issues

@shimks
Copy link
Contributor

shimks commented May 3, 2018

Technically, the acceptance criteria is already done. @hacksparrow Would you consider the issue non-relevant or do you have specific items in mind that allow express-specific aspects to be compatible with lb4?

@hacksparrow @bajtos @raymondfeng Please hash out the acceptance criteria with more details to how much we want express to be used in lb4.

EDIT: turning this into a spike

@shimks shimks changed the title Mount LB4 apps as Express middleware [SPIKE] Mount LB4 apps as Express middleware May 3, 2018
@shimks shimks changed the title [SPIKE] Mount LB4 apps as Express middleware [SPIKE] Figure out the responsibility between express middleware and LB4 routing and sequencing May 3, 2018
@bajtos
Copy link
Member

bajtos commented May 16, 2018

For DP3, we agreed with @raymondfeng that we are not going to expose Express routing/middleware to app developers yet. I am removing this story from DP3 release and epic.

@bajtos bajtos added Core-GA REST Issues related to @loopback/rest package and REST transport in general feature and removed DP3 labels May 16, 2018
@bajtos bajtos added post-GA and removed Core-GA labels Jun 25, 2018
@dhmlau dhmlau removed the non-DP3 label Aug 23, 2018
@dhmlau dhmlau removed the post-GA label Nov 2, 2018
@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Oct 28, 2019
@stale
Copy link

stale bot commented Nov 27, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature REST Issues related to @loopback/rest package and REST transport in general stale
Projects
None yet
Development

No branches or pull requests

4 participants