Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Relations Preview #1032

Closed
dhmlau opened this issue Feb 22, 2018 · 3 comments
Closed

Model Relations Preview #1032

dhmlau opened this issue Feb 22, 2018 · 3 comments
Labels

Comments

@dhmlau
Copy link
Member

dhmlau commented Feb 22, 2018

Assumption: Maintain 1-to-1 relationship between model and datasource due to juggler constraint

DP3 scope

  • Show the programming model, gather feedback.
  • must have: HasMany relation
  • stretch goal: BelongsTo relation

Out of DP3 scope

  • Additional relation types (HasAndBelongsToMany, polymorphic & embedded relations, etc.)
  • Composite keys
  • CLI tooling
@bajtos bajtos changed the title Model Relation - Epic Model and DataSource relationship - Epic Feb 26, 2018
@dhmlau dhmlau changed the title Model and DataSource relationship - Epic Model Relations - Epic Apr 19, 2018
@dhmlau dhmlau added the DP3 label Apr 19, 2018
@bajtos bajtos changed the title Model Relations - Epic Model Relations Preview May 16, 2018
@dhmlau
Copy link
Member Author

dhmlau commented May 24, 2018

Extracting the to-do list from #995, I've created the following tasks:

Out of scope for DP3

@bajtos
Copy link
Member

bajtos commented May 28, 2018

In the past (#995 (comment)), I wrote:

We need a vision of how to iteratively deliver small increments of functionality, where each increment is something that our users (LB4 app developers) can start using. In our call, we were discussing the first smallest step. IIRC, it was HasMany with a single operation find, covering both repository/persistence and REST API in a controller method. The next step as I remember it: add create method to repository/persistence layer and expose it in REST API as a new controller method. After that, I think we can go wider - one task can be adding all remaining HasMany methods, another task can be BelongsTo. Many of the tasks you listed make sense to do after those two initial tasks are done. Some of them should be probably done as part of those two initial tasks. For example, "remove execute" and "split Repository interface" - I think that should be done in the extent needed by those baby steps.

@dhmlau The task list above does not provide those small increments of functionality. I am proposing to add the following stories, where the first story should be already in progress by @b-admike:

  1. HasMany with a single operation find, covering both repository/persistence and REST API in a controller method.
  2. Add create method to repository/persistence layer and expose it in REST API as a new controller method.
  3. Add all remaining HasMany methods.

#1355 and #1356 may partially overlap with those three new stories. It's ok to keep the around as
a reminder to verify that the changes were indeed made as part of those three vertical increments outlined above.

@dhmlau
Copy link
Member Author

dhmlau commented Jul 20, 2018

closing as done.

@dhmlau dhmlau closed this as completed Jul 20, 2018
@bajtos bajtos added the p1 label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants