From 15dd2dbd962882a63edb2227b2688dbdc961be80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Fri, 12 Jan 2018 16:17:50 +0100 Subject: [PATCH] fix(build): move no-unused-variables to tslint.build.json In the latest version of tslint, the rule "no-unused-variables" requires type information and therefore cannot be run on the fly from VS Code. This commit move the configuration of "no-unused-variables" from tsling.common.json to tslint.build.json to avoid warnings printed to VS Code console: Warning: The 'no-unused-variable' rule requires type information. --- packages/build/config/tslint.build.json | 2 +- packages/build/config/tslint.common.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/build/config/tslint.build.json b/packages/build/config/tslint.build.json index a23af25e7146..84e7890b1b0e 100644 --- a/packages/build/config/tslint.build.json +++ b/packages/build/config/tslint.build.json @@ -9,12 +9,12 @@ "rules": { // These rules find errors related to TypeScript features. - // These rules catch common errors in JS programming or otherwise // confusing constructs that are prone to producing bugs. "await-promise": true, "no-floating-promises": true, + "no-unused-variable": true, "no-void-expression": [true, "ignore-arrow-function-shorthand"] } } diff --git a/packages/build/config/tslint.common.json b/packages/build/config/tslint.common.json index b8d46f249da5..78d35a3e62f3 100644 --- a/packages/build/config/tslint.common.json +++ b/packages/build/config/tslint.common.json @@ -20,7 +20,6 @@ "no-shadowed-variable": true, "no-string-throw": true, "no-unused-expression": true, - "no-unused-variable": true, "no-var-keyword": true, "triple-equals": [true, "allow-null-check", "allow-undefined-check"] }