Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filter implementation with loopback-filters #1529

Closed
bajtos opened this issue Dec 14, 2017 · 9 comments
Closed

Replace filter implementation with loopback-filters #1529

bajtos opened this issue Dec 14, 2017 · 9 comments

Comments

@bajtos
Copy link
Member

bajtos commented Dec 14, 2017

Let's deliver the promise we made in our [docs] long time ago:

We plan to convert all modules to use loopback-filter, so it will become LoopBack’s common “built-in” filtering mechanism.

Right now, loopback-filters are always behind the "real" loopback implementations and people have to port new features from loopback-datasource-juggler to loopback-filters to keep them up to date (see e.g. strongloop/loopback-filters#13, strongloop/loopback-filters#10, strongloop/loopback-filters#3, strongloop/loopback-filters#20).

Once we switch juggler to use loopback-filters, there will be only a single place where to add new filtering features.

Important note: this change should be fully backwards compatible, all existing tests in loopback-datasource-juggler and loopback should keep passing. This will most likely require improvements to be made in loopback-filters to get them feature parity with what we have in juggler right now.

@aatif-lahore
Copy link

Do you have updated loopback-filters?

@bajtos
Copy link
Member Author

bajtos commented Jan 15, 2018

@aatifhussain I am afraid I don't understand your question, what kind of updates do you have in mind? AFAIK, no action related to this issue has been made yet.

@aatif-lahore
Copy link

@bajtos You got it right, Thank you.

@privateOmega
Copy link

@bajtos I have put in a PR 15 days ago pending review.

@bajtos
Copy link
Member Author

bajtos commented Feb 13, 2018

@privateOmega thank you for pinging me, I reviewed your strongloop/loopback-filters#26 and left some comments, PTAL.

@stale
Copy link

stale bot commented Apr 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 14, 2018
@dhmlau
Copy link
Member

dhmlau commented Apr 16, 2018

not stale. PR in review.

@stale stale bot removed the stale label Apr 16, 2018
@stale
Copy link

stale bot commented Jun 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 15, 2018
@stale
Copy link

stale bot commented Jun 29, 2018

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants