-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace filter implementation with loopback-filters #1529
Comments
Do you have updated loopback-filters? |
@aatifhussain I am afraid I don't understand your question, what kind of updates do you have in mind? AFAIK, no action related to this issue has been made yet. |
@bajtos You got it right, Thank you. |
@bajtos I have put in a PR 15 days ago pending review. |
@privateOmega thank you for pinging me, I reviewed your strongloop/loopback-filters#26 and left some comments, PTAL. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale. PR in review. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Let's deliver the promise we made in our [docs] long time ago:
Right now, loopback-filters are always behind the "real" loopback implementations and people have to port new features from loopback-datasource-juggler to loopback-filters to keep them up to date (see e.g. strongloop/loopback-filters#13, strongloop/loopback-filters#10, strongloop/loopback-filters#3, strongloop/loopback-filters#20).
Once we switch juggler to use loopback-filters, there will be only a single place where to add new filtering features.
Important note: this change should be fully backwards compatible, all existing tests in loopback-datasource-juggler and loopback should keep passing. This will most likely require improvements to be made in loopback-filters to get them feature parity with what we have in juggler right now.
The text was updated successfully, but these errors were encountered: