-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector does not support empty update #339
Comments
Both the Cloudant connector and the in memory connector allow for empty updates. |
Can we get any feedback on this? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@dhmlau I do not believe this has been fixed. Any chance we can keep this open and investigate? |
Sure. cc @bajtos |
Based on the report, it seems to me that the problem is in individual connectors that are not prepared to handle the case where the To ensure all connectors work consistently, we should add a test to |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Description/Steps to reproduce
run patchAttributes on a model and provide an empty object as the payload, e.g.
PATCH /api/users/1 {}
Expected result
200 or 204, no error thrown
Actual result
500 thrown, connector sends invalid SQL to the DB, e.g.
UPDATE "public"."assettype" SET WHERE "id"=931;
Additional information
darwin x64 8.11.1
The text was updated successfully, but these errors were encountered: