Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using protocol mongdb+srv fails because it is not valid to set port in connection url #496

Closed
jareeve opened this issue Feb 6, 2019 · 2 comments

Comments

@jareeve
Copy link
Contributor

jareeve commented Feb 6, 2019

Description/Steps to reproduce

If protocol in the datasource is set to mongdb+srv then the url constructed by the connector also adds in the default port but it not valid to specify the port in the url and a client error is thrown.

If I modify the connector code to not add in the port to the url when protocol is mongodb+srv then it all works fine.

I am testig using a database on mongodb.com.

Link to reproduction sandbox

Expected result

Additional information

I have the code changes that fix this issue. I will provide the changes in a PR and link it from here. Feel free to reject the pr if you have a better way to fix it.

Many thanks, John.

@jareeve
Copy link
Contributor Author

jareeve commented Feb 6, 2019

#497

@dhmlau
Copy link
Member

dhmlau commented Apr 18, 2019

Closing this issue as PR #497 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants