Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux, BSD, etc: Install .desktop and .appstream.xml #402

Closed
lmoureaux opened this issue Apr 4, 2021 · 2 comments · Fixed by #613
Closed

Linux, BSD, etc: Install .desktop and .appstream.xml #402

lmoureaux opened this issue Apr 4, 2021 · 2 comments · Fixed by #613
Assignees
Labels
bug Something isn't working

Comments

@lmoureaux
Copy link
Contributor

lmoureaux commented Apr 4, 2021

For desktop environments to find them, the .desktop files need be installed to share/applications. The AppStream XML files go to share/metainfo (and not share/appdata like Freeciv 2.6 does 🤦). This should be done on Linux & friends, let's say any UNIX that is not 🍎.

(share is ${CMAKE_INSTALL_DATAROOTDIR})

@lmoureaux lmoureaux added the bug Something isn't working label Apr 4, 2021
@jwrober jwrober self-assigned this Apr 5, 2021
@jwrober
Copy link
Collaborator

jwrober commented Apr 28, 2021

@lmoureaux On a recent Linux compile and install I got these files in my local share directory along with the binaries and other files.

image

So I think this is fixed/closed but can't seem to find the commit that changed install behavior. Could use someone else to test and see if they get similar behavior.

@lmoureaux
Copy link
Contributor Author

On a recent Linux compile and install I got these files in my local share directory along with the binaries and other files.

Sorry I missed this comment for too long. Installing the .in files is certainly not correct, the paths inside should be substituted first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants