Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoRev is not picking up v3.1.x releases on master branch #1922

Closed
jwrober opened this issue Apr 23, 2023 · 7 comments · Fixed by #2268
Closed

AutoRev is not picking up v3.1.x releases on master branch #1922

jwrober opened this issue Apr 23, 2023 · 7 comments · Fixed by #2268
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.
Milestone

Comments

@jwrober
Copy link
Collaborator

jwrober commented Apr 23, 2023

Describe the bug
AutoRev is not picking up v3.1.x releases on master branch

To Reproduce
Steps to reproduce the behavior:

  1. Tag a release on master branch
  2. Notice that the compiled binaries show incorrect version.

https://github.com/longturn/freeciv21/actions/runs/4779208059/jobs/8496507906

Expected behavior
AutoRev properly grabs the tag

Screenshots
image

image

Platform and version (please complete the following information):

  • OS: [e.g. Windows 10]
  • Freeciv21 version: v3.1-alpha.1
  • Ruleset/Longturn game (if applicable): [e.g. classic or LTEx24]

Additional context
Add any other context about the problem here.

@jwrober jwrober added bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools. labels Apr 23, 2023
@lmoureaux
Copy link
Contributor

Related to #1825

@jwrober
Copy link
Collaborator Author

jwrober commented Apr 24, 2023

Also potentially related to #844

@lmoureaux
Copy link
Contributor

This is the caveat noted in #1820, it works properly now.

@jwrober jwrober added this to the v3.1-stable milestone Mar 30, 2024
@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

I am not sure this is an issue any longer. Recent runs in both stable and master branches show the correct tag. We can watch to see what happens when we push 3.1-alpha.6

@lmoureaux
Copy link
Contributor

Quoting from #1820:

Caveat: When creating the v3.1-alpha.1 tag on top of a v3.1-dev, the version will stay at v3.1-dev until the AutoRevision PR gets merged. Even after it is merged, someone doing a git checkout of v3.1-alpha.1 will get the v3.1-dev tag.

So it will happen again for 3.2-alpha.1

@jwrober
Copy link
Collaborator Author

jwrober commented Apr 5, 2024

@jwrober
Copy link
Collaborator Author

jwrober commented Apr 5, 2024

I wonder if we can have "release" workflow happen after "build" completes and then we can add a git fetch to "release"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants