Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpl schema will accept everything as valid when "removeEmptyStrings" field is used inside clean method #481

Open
klaucode opened this issue Mar 26, 2023 · 1 comment

Comments

@klaucode
Copy link

klaucode commented Mar 26, 2023

Thank you for the GREAT package. I found only a probably small problem. When I'm validating complicated JSON with SimpleSchema, which contains oneOf with next (child) instances of SimpleSchema, it's making a strange thing.

If I'm using following clean options, validation works. But If I will uncomment the commented line, validation is not working correctly and every input will evaluate as valid.

let s = new SimpleSchema(options, { clean: { filter: true, autoConvert: true, // removeEmptyStrings: false, trimStrings: true, getAutoValues: true, removeNullsFromArrays: true }, requiredByDefault: true });

@github-actions
Copy link

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

@klaucode klaucode changed the title Simpl schema will accept everything as valid when "removeEmptyStrings" field is used on clean method Simpl schema will accept everything as valid when "removeEmptyStrings" field is used inside clean method Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant