Skip to content

Latest commit

 

History

History
28 lines (17 loc) · 1.58 KB

cran-comments.md

File metadata and controls

28 lines (17 loc) · 1.58 KB

Resubmission #2

Comment #1

We would highly appreciate if you could put at least 'JavaScript' into quotation marks, please.

I have put both 'JavaScript' and 'Lemmy' into quotes for consistency.

Comment #2

"Using foo:::f instead of foo::f allows access to unexported objects. This is generally not recommended, as the semantics of unexported objects may be changed by the package author in routine maintenance." Please omit one colon. Used ::: in documentation: man/lemmy_get_comment.Rd: if (remmy:::is_lemmy_world()) (if (getRversion() >= "3.4") withAutoprint else force)({ })

The is_lemmy_world() function (implemented id "R/test-helpers.R") is a helper to determine whether the Lemmy server is reachable and thus whether the examples should be run as part of R CMD check.

is_lemmy_world() is not exported, as it is not intended to be used by users, and the ::: is therefore necessary. However, users would not be able to see it in the documentation anyway, as the condition in @examplesIf is placed inside a \dontshow{} block in the rendered .Rd files, so I do not think it is a problem.

The same approach of using internal helper functions for conditional execution of examples is used by several CRAN packages such as dm, tune, and stacks.

R CMD check results

0 errors | 0 warnings | 1 note

  • This is a new release.