From 1eb1bbdfbb07d19152acc7f0143bb53386c54fc8 Mon Sep 17 00:00:00 2001 From: kokeshiM0chi <52264064+kokeshiM0chi@users.noreply.github.com> Date: Thu, 7 Sep 2023 15:47:18 +0900 Subject: [PATCH] docs: add comment about ordering of addresses in wasmplus (#107) * chore: Added comment about ordering of addresses * chore: add this pr to change.log * fix: fix singular * fix: fix pr title * fix: fix singular * fix: Correct uppercase letters to lowercase letters * fix: Correct to specify the type of elements in List of addresses --- CHANGELOG.md | 1 + docs/proto/proto-docs.md | 8 ++++---- proto/lbm/wasm/v1/query.proto | 2 +- x/wasmplus/types/query.pb.go | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93b45b204d..b693b72616 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ * [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes) * [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md * [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query +* [\#107](https://github.com/Finschia/wasmd/pull/107) add comment about ordering of addresses in wasmplus ## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22 diff --git a/docs/proto/proto-docs.md b/docs/proto/proto-docs.md index 1ca5b041d3..f8ff17ead2 100644 --- a/docs/proto/proto-docs.md +++ b/docs/proto/proto-docs.md @@ -1506,10 +1506,10 @@ QueryInactiveContractsResponse is the response type for the Query/InactiveContract RPC method. -| Field | Type | Label | Description | -| ----- | ---- | ----- | ----------- | -| `addresses` | [string](#string) | repeated | addresses is the inactive address list | -| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | +| Field | Type | Label | Description | +| ----- | ---- | ----- |---------------------------------------------------------------------------------| +| `addresses` | [string](#string) | repeated | addresses is the inactive address list of strings, in ascending order of byte format | +| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | diff --git a/proto/lbm/wasm/v1/query.proto b/proto/lbm/wasm/v1/query.proto index 7c539e4211..5f7eaea8b8 100644 --- a/proto/lbm/wasm/v1/query.proto +++ b/proto/lbm/wasm/v1/query.proto @@ -34,7 +34,7 @@ message QueryInactiveContractsRequest { // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. message QueryInactiveContractsResponse { - // addresses is the inactive address list + // addresses is the inactive address list of strings, in ascending order of byte format repeated string addresses = 1; // pagination defines the pagination in the response diff --git a/x/wasmplus/types/query.pb.go b/x/wasmplus/types/query.pb.go index 788a8a6d74..c990333a89 100644 --- a/x/wasmplus/types/query.pb.go +++ b/x/wasmplus/types/query.pb.go @@ -82,7 +82,7 @@ var xxx_messageInfo_QueryInactiveContractsRequest proto.InternalMessageInfo // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. type QueryInactiveContractsResponse struct { - // addresses is the inactive address list + // addresses is the inactive address list of strings, in ascending order of byte format Addresses []string `protobuf:"bytes,1,rep,name=addresses,proto3" json:"addresses,omitempty"` // pagination defines the pagination in the response Pagination *query.PageResponse `protobuf:"bytes,2,opt,name=pagination,proto3" json:"pagination,omitempty"`