some codes can be optimization!

[xgqfrms-GitHub]

https://www.packtpub.com/application-development/learning-javascript-data-structures-and-algorithms

not too good

https://github.com/loiane/javascript-datastructures-algorithms/blob/first-edition/chapter06/01-Set.js

https://github.com/loiane/javascript-datastructures-algorithms/blob/master/chapter06/01-Set.js

https://github.com/loiane/javascript-datastructures-algorithms/blob/master/chapter06/01-Set2.js

    this.intersection = function(otherSet){
        var intersectionSet = new Set(); //{1}

        var values = this.values();
        for (var i=0; i<values.length; i++){ //{2}
            if (otherSet.has(values[i])){    //{3}
                intersectionSet.add(values[i]); //{4}
            }
        }

        return intersectionSet;
    };


    this.intersection = function(otherSet){
        let intersectionSet = new Set(); //{1}

        let values = this.values();
        for (let i=0; i<values.length; i++){ //{2}
            if (otherSet.has(values[i])){    //{3}
                intersectionSet.add(values[i]); //{4}
            }
        }

        return intersectionSet;
    };



        intersection(otherSet){
            let intersectionSet = new Set();

            let values = this.values();
            for (let i=0; i<values.length; i++){
                if (otherSet.has(values[i])){
                    intersectionSet.add(values[i]);
                }
            }

            return intersectionSet;
        }

good

    this.intersection = (otherSet) => {
        let intersectionSet = new Set();
        // self
        let values = this.values();
        let othervalues = otherSet.values();
        let small_size = ((othervalues.length - values.length) > 0 ? values : othervalues);
        // small & reduce iterate times 
        for (var i = 0; i < small_size.length; i++) {
            if (small_size.has(values[i])) {
                intersectionSet.add(values[i]);
            }
        }
        return intersectionSet;
    };

javascript-datastructures-algorithms

https://github.com/loiane/javascript-datastructures-algorithms

https://github.com/gildata/RAIO/issues/167#issuecomment-330818729

[loiane]

Thank you! Will review and update the code!

[loiane]

Code updated in third-ed branch

[xyzdata]

another version

    this.intersection = (otherSet) => {
        let intersectionSet = new Set(),
            values = this.values(),
            otherValues = otherSet.values(),
            smallSize = ((otherValues.length - values.length) > 0 ? values : otherValues);
        // small & reduce iterate times
        smallSize.forEach((value) => {
            if (smallSize.includes(value)) {
                intersectionSet.add(value);
            }
        });
        return intersectionSet;
    };