Enable SSL, make reporter a daemon thread #118
Conversation
| @@ -67,7 +67,7 @@ public void testOnServerRestart() throws InterruptedException { | |||
| int connectTimeout = 1000; | |||
| int socketTimeout = 1000; | |||
| GraphiteClient client = new GraphiteClient("bla-host.com", "bla-service", "localhost", | |||
| port, connectTimeout, socketTimeout, 20000, | |||
| port, false, connectTimeout, socketTimeout, 20000, | |||
There was a problem hiding this comment.
Can you please add an integration test to see that the functionality works?
There was a problem hiding this comment.
Ah, sorry, setting up an ssl-enabled graphite is fairly complicated, and doing it in an integration test more so, and I don't have the time right now to get it working. I understand if you don't want to merge without a test though. Thanks!
There was a problem hiding this comment.
@elahrvivaz Even if you use testcontainers? If you already did once for manual testing, it's only a matter of writing the configuration file for Graphite no?
There was a problem hiding this comment.
ah, well I didn't set up the instance I've been testing on, and I'm not familiar with testcontainers :(
There was a problem hiding this comment.
@elahrvivaz Testcontainers is fairly easy to work with. You have a great example at GraphiteITest. Take a few minutes to review it - I'll happy to assist with any questions you may have.
|
@elahrvivaz Would you like to continue on this? |
|
I'll close it for now, if someone else wants to pick it up feel free! |
Closes #116