Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support base64 format OIDC_PRIVATE_KEYS config in .env file #1903

Merged

Conversation

xiaoyijun
Copy link
Contributor

@xiaoyijun xiaoyijun commented Sep 8, 2022

Summary

Support base64 format OIDC_PRIVATE_KEYS config in .env file

Testing

UT and test locally.

@xiaoyijun xiaoyijun requested a review from a team September 8, 2022 08:07
@xiaoyijun xiaoyijun self-assigned this Sep 8, 2022
@linear
Copy link

linear bot commented Sep 8, 2022

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

COMPARE TO master

Total Size Diff 📈 +626 Bytes

Diff by File
Name Diff
packages/core/src/env-set/oidc.test.ts 📈 +403 Bytes
packages/core/src/env-set/oidc.ts 📈 +223 Bytes

@github-actions github-actions bot added feature Cool stuff size/s labels Sep 8, 2022
@xiaoyijun xiaoyijun marked this pull request as draft September 8, 2022 09:01
@xiaoyijun xiaoyijun force-pushed the xiaoyijun-log-3916-encode-oidc_private_keys-to-base64-in branch from 94c202a to a9201bc Compare September 8, 2022 09:26
@xiaoyijun xiaoyijun changed the title feat(core)!: read OIDC_PRIVATE_KEYS in base64 format from .env file feat(core): support base64 format OIDC_PRIVATE_KEYS config in .env file Sep 8, 2022
@xiaoyijun xiaoyijun changed the title feat(core): support base64 format OIDC_PRIVATE_KEYS config in .env file feat(core): support base64 format OIDC_PRIVATE_KEYS config in .env file Sep 8, 2022
@xiaoyijun xiaoyijun marked this pull request as ready for review September 8, 2022 09:29
packages/core/src/env-set/oidc.test.ts Outdated Show resolved Hide resolved
@xiaoyijun xiaoyijun enabled auto-merge (squash) September 8, 2022 09:37
@xiaoyijun xiaoyijun enabled auto-merge (squash) September 8, 2022 09:38
@xiaoyijun xiaoyijun merged commit 5bdb675 into master Sep 8, 2022
@xiaoyijun xiaoyijun deleted the xiaoyijun-log-3916-encode-oidc_private_keys-to-base64-in branch September 8, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants