fix(core): fix ac & ui proxy under subpath deployment #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ac & ui procy under subpath deployment
LOG-3808 Double check if Logto can be deployed in subpath
e.g. i'm worry about ui/ac routing. should do it this cycle |
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/middleware/koa-root-proxy.ts | 📈 +147 Bytes |
| packages/core/src/middleware/koa-spa-session-guard.ts | 📈 +147 Bytes |
| packages/core/src/middleware/koa-welcome-proxy.test.ts | 📈 +110 Bytes |
| packages/core/src/middleware/koa-welcome-proxy.ts | 📈 +168 Bytes |
jomerventolero
approved these changes
Aug 11, 2022
wangsijie
approved these changes
Aug 12, 2022
jomerventolero
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix ac & ui proxy redirect logic under subpath deployment
Instead of redirecting to the root path, should read the endpoint from envSet.
Testing
test locally
@logto-io/eng