feat(console): show app secret #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/components/CopyToClipboard/index.module.scss | 📈 +92 Bytes |
| packages/console/src/components/CopyToClipboard/index.tsx | 📈 +805 Bytes |
| packages/console/src/icons/EyeClosed.tsx | 📈 +1.09 KB |
| packages/console/src/pages/ApplicationDetails/components/Settings.tsx | 📈 +367 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/application-details.ts | 📈 +36 Bytes |
| packages/phrases/src/locales/ko-kr/translation/admin-console/application-details.ts | 📈 +36 Bytes |
| packages/phrases/src/locales/tr-tr/translation/admin-console/application-details.ts | 📈 +42 Bytes |
| packages/phrases/src/locales/zh-cn/translation/admin-console/application-details.ts | 📈 +36 Bytes |
|
The "Eye" icon should be closed when hiding the secret |
charIeszhao
reviewed
Aug 2, 2022
|
update: add eye close icon
|
wangsijie
force-pushed
the
sijie-log-3839-app-secret
branch
from
ab43fdc
to
a094ec1
Compare
darcyYe
reviewed
Aug 3, 2022
packages/console/src/pages/ApplicationDetails/components/Settings.tsx
Outdated
Show resolved
Hide resolved
charIeszhao
reviewed
Aug 3, 2022
charIeszhao
reviewed
Aug 3, 2022
charIeszhao
reviewed
Aug 3, 2022
charIeszhao
reviewed
Aug 3, 2022
charIeszhao
reviewed
Aug 3, 2022
charIeszhao
reviewed
Aug 3, 2022
wangsijie
force-pushed
the
sijie-log-3839-app-secret
branch
from
a094ec1
to
0793a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show app secret in AC for traditional app.
Testing