-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): resolve some core no-restricted-syntax lint error #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/core/package.json | 📈 +37 Bytes |
packages/core/src/database/utils.ts | 📈 +209 Bytes |
packages/core/src/lib/passcode.test.ts | 📈 +13 Bytes |
packages/core/src/middleware/koa-guard.ts | 📈 +22 Bytes |
packages/core/src/middleware/koa-i18next.ts | 📈 +53 Bytes |
packages/core/src/middleware/koa-oidc-error-handler.ts | 📈 +138 Bytes |
packages/core/src/middleware/koa-slonik-error-handler.ts | 📈 +218 Bytes |
packages/core/src/routes/swagger.ts | 📈 +61 Bytes |
packages/core/src/utils/oidc-provider-event-listener.ts | 📈 +32 Bytes |
packages/core/src/utils/test-utils.ts | 📈 +86 Bytes |
packages/core/src/utils/zod.ts | 📈 +82 Bytes |
gao-sun
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coool
simeng-li
force-pushed
the
simeng-log-3657
branch
from
July 20, 2022 03:42
e193ebe
to
3dfa0cc
Compare
gao-sun
approved these changes
Jul 20, 2022
simeng-li
force-pushed
the
simeng-log-3657
branch
from
July 20, 2022 06:32
112ae30
to
f7c2a26
Compare
resolve some core no-restricted-syntax lint error
simeng-li
force-pushed
the
simeng-log-3657
branch
from
July 20, 2022 09:44
f7c2a26
to
7a58441
Compare
remove OpenAPIV3 enum instance reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve some core no-restricted-syntax lint errors.
Comment added for those hard-to-bypass issues.
Testing
test locally
@logto-io/eng