Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve some core no-restricted-syntax lint error #1606

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

simeng-li
Copy link
Contributor

Summary

Resolve some core no-restricted-syntax lint errors.
Comment added for those hard-to-bypass issues.

Testing

test locally
@logto-io/eng

@linear
Copy link

linear bot commented Jul 19, 2022

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

COMPARE TO master

Total Size Diff 📈 +851 Bytes

Diff by File
Name Diff
packages/core/package.json 📈 +37 Bytes
packages/core/src/database/utils.ts 📈 +209 Bytes
packages/core/src/lib/passcode.test.ts 📈 +13 Bytes
packages/core/src/middleware/koa-guard.ts 📈 +22 Bytes
packages/core/src/middleware/koa-i18next.ts 📈 +53 Bytes
packages/core/src/middleware/koa-oidc-error-handler.ts 📈 +138 Bytes
packages/core/src/middleware/koa-slonik-error-handler.ts 📈 +218 Bytes
packages/core/src/routes/swagger.ts 📈 +61 Bytes
packages/core/src/utils/oidc-provider-event-listener.ts 📈 +32 Bytes
packages/core/src/utils/test-utils.ts 📈 +86 Bytes
packages/core/src/utils/zod.ts 📈 +82 Bytes

Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coool

packages/core/src/middleware/koa-slonik-error-handler.ts Outdated Show resolved Hide resolved
remove OpenAPIV3 enum instance reference
@simeng-li simeng-li merged commit c56ddec into master Jul 20, 2022
@simeng-li simeng-li deleted the simeng-log-3657 branch July 20, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants