Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct templates based on Elasticsearch versions #401

Closed
suyograo opened this issue Mar 28, 2016 · 8 comments
Closed

Use correct templates based on Elasticsearch versions #401

suyograo opened this issue Mar 28, 2016 · 8 comments
Assignees

Comments

@suyograo
Copy link
Contributor

suyograo commented Mar 28, 2016

ES 5.0 has numerous mapping changes as described here #386. Much effort has been put into making this a backward compatible change recently, but we'd still like users to migrate to the new mapping settings and not carry the old cruft around.

As such, we should:

  • Ship both ES 2.x (old) and ES 5.0 (new) templates
  • Enhance this plugin to detect if ES 5.0 is running (when the first attempt to upload template is made), and if so, use the 5.0 template version. If ES version 2.x is running, use the other template.

Note: We should do this only when default template is used and the existing template* configs should apply to both the versions

We may need to introduce a new config option to select different paths for 5.0 and 2.x templates on disk.

@pickypg
Copy link
Contributor

pickypg commented Mar 28, 2016

I came back to this issue to double check that this part was here:

We should do this only when default template is used.

I just wanted to call it out for whoever implements it because otherwise it will break some things. :)

@suyograo
Copy link
Contributor Author

Thanks @pickypg . Made it stick out :)

@tsg
Copy link

tsg commented Apr 21, 2016

What does "force upgrade" mean? Overwrite it?

@suyograo
Copy link
Contributor Author

@tsg when I mean't force upgrade, I actually meant forcing users to upgrade to a 5.0 template if they are running against ES 5.0. If they already have a logstash template, we wouldn't overwrite it.

@acchen97
Copy link
Contributor

After discussion with @suyograo and @jordansissel we plan to backport this logic for 2.4 as well. Therefore, both LS 2.4 and 5.0 will have compatible default templates with both ES 2.x and 5.0.

@jsvd jsvd self-assigned this Jun 29, 2016
@suyograo suyograo assigned purbon and unassigned untergeek and jsvd Jul 7, 2016
@suyograo
Copy link
Contributor Author

@jsvd moving this to @purbon

@suyograo suyograo changed the title Force upgrade templates if ES 5.0 is detected Use correct templates based on Elasticsearch versions Jul 12, 2016
@suyograo suyograo assigned jsvd and unassigned purbon Jul 19, 2016
@suyograo
Copy link
Contributor Author

@jsvd will start on this.

For ref: beats did something similar as well: elastic/beats#1993

@suyograo
Copy link
Contributor Author

Fixed in #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants