-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct templates based on Elasticsearch versions #401
Comments
I came back to this issue to double check that this part was here:
I just wanted to call it out for whoever implements it because otherwise it will break some things. :) |
Thanks @pickypg . Made it stick out :) |
What does "force upgrade" mean? Overwrite it? |
@tsg when I mean't force upgrade, I actually meant forcing users to upgrade to a 5.0 template if they are running against ES 5.0. If they already have a |
After discussion with @suyograo and @jordansissel we plan to backport this logic for 2.4 as well. Therefore, both LS 2.4 and 5.0 will have compatible default templates with both ES 2.x and 5.0. |
@jsvd will start on this. For ref: beats did something similar as well: elastic/beats#1993 |
Fixed in #455 |
ES 5.0 has numerous mapping changes as described here #386. Much effort has been put into making this a backward compatible change recently, but we'd still like users to migrate to the new mapping settings and not carry the old cruft around.
As such, we should:
Note: We should do this only when default template is used and the existing template* configs should apply to both the versions
We may need to introduce a new config option to select different paths for 5.0 and 2.x templates on disk.
The text was updated successfully, but these errors were encountered: