Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency for accepted settings for ssl_verify_mode #358

Open
breml opened this issue Feb 7, 2019 · 0 comments
Open

Inconsistency for accepted settings for ssl_verify_mode #358

breml opened this issue Feb 7, 2019 · 0 comments
Assignees

Comments

@breml
Copy link

breml commented Feb 7, 2019

The documentation for ssl_verify_mode lists the following allowed values: none, peer, force_peer.

If an invalid configuration is provided, the following exception is raised (https://github.com/logstash-plugins/logstash-input-beats/blob/master/lib/logstash/inputs/beats.rb#L148): Using verify_modeset to PEER or FORCE_PEER, requires the configuration ofcertificate_authorities` where

  1. the setting is called verify_mode instead of ssl_verify_mode
  2. the allowed settings are written in all uppercase

In the code there are locations, where the case for this settings does not matter (https://github.com/logstash-plugins/logstash-input-beats/blob/master/lib/logstash/inputs/beats.rb#L180) and other locations, where case indeed does matter (https://github.com/logstash-plugins/logstash-input-beats/blob/master/lib/logstash/inputs/beats.rb#L224).

Stumbled over this, while debugging a similar situation as mentioned in #196 (PR: #182).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants