Added device model and brand to user_agent output #77
Conversation
| @@ -27,7 +28,44 @@ | |||
| */ | |||
| final class Device { | |||
|
|
|||
| public static String fromMap(Map<String, String> m) { | |||
| return m.get("family"); | |||
| public final String family; | |||
There was a problem hiding this comment.
seems that the uap-java does not have these changes:
https://github.com/ua-parser/uap-java/blob/master/src/main/java/ua_parser/Device.java
so this was written from scratch or copied from somewhere else?
There was a problem hiding this comment.
@kares this was written from scratch (similar to the OS class). I did not find a reference in the java class that it was from the uap-java project.
There was a problem hiding this comment.
Now that you pointed me to it - there is a PR ua-parser/uap-java#37 in the uap-java project that asks for same functionality but it hasn't seen action since early 2020. If I had seen it, I would have mentioned it.
.github/workflows/ci.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-20.04] | ||
| ruby: [jruby-9.1.17.0] |
There was a problem hiding this comment.
we do not want this file, currently the plugin tests against Travis CI, for whatever reason the CI did not kick-off
maybe try removing the file - build tried running against 55c2d94 but somehow CI mis-detected the commit:
There was a problem hiding this comment.
I deleted the file and pushed again
| @device_family_field = "#{target}#{@device_family_field}" | ||
| @device_brand_field = ecs_select[disabled: "[#{@prefix}device]", v1: '[device][brand]'] | ||
| @device_brand_field = "#{target}#{@device_brand_field}" | ||
| @device_model_field = ecs_select[disabled: "[#{@prefix}device]", v1: '[device][model]'] |
There was a problem hiding this comment.
these are going to be problematic as ATM ECS (1.11) only supports user_agent.device.name
There was a problem hiding this comment.
@kares is there an "experimental" switch that could enable this behavior? Such that it is still compliant?
|
@kares how do we want to proceed here? |
Java tests are passing - the JRuby ones - I have some question.