From 22bce85377a7fd702b3acbbd47bf90e303f91bbe Mon Sep 17 00:00:00 2001 From: Phil Clay Date: Sun, 7 Nov 2021 10:03:49 -0800 Subject: [PATCH 1/2] Run tests against Jackson 2.12 to ensure runtime compatibility --- .github/workflows/build.yml | 4 ++++ pom.xml | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7b1e5bbb..cf62565c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,6 +38,10 @@ jobs: - name: Build run: ./mvnw --batch-mode --no-transfer-progress --show-version --settings .github/maven/settings.xml verify + # Run tests against Jackson 2.12 to ensure runtime compatibility (do not recompile) + - name: Test Jackson 2.12 + run: ./mvnw --batch-mode --no-transfer-progress --show-version --settings .github/maven/settings.xml -Djackson.version=2.12.5 surefire:test + - name: Upload Test Reports uses: actions/upload-artifact@v2 if: ${{ always() }} diff --git a/pom.xml b/pom.xml index 349c2ea7..7d40611a 100644 --- a/pom.xml +++ b/pom.xml @@ -455,6 +455,13 @@ org.apache.maven.plugins maven-surefire-plugin ${maven-surefire-plugin.version} + + + ${project.build.directory}/surefire-reports/jackson-${jackson.version} + From 483362fa01fbb13a4c135b9eab57b093fca7459c Mon Sep 17 00:00:00 2001 From: Phil Clay Date: Sun, 7 Nov 2021 13:39:44 -0800 Subject: [PATCH 2/2] Specify minimum jackson version in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0f361c87..c3f29726 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ then ensure the required dependencies (and appropriate versions) as specified in from the maven repository exist on the runtime classpath. Specifically, the following need to be available on the runtime classpath: -* jackson-databind / jackson-core / jackson-annotations +* jackson-databind / jackson-core / jackson-annotations >= 2.12.0 * logback-core >= 1.2.0 * logback-classic >= 1.2.0 (required for logging _LoggingEvents_) * logback-access >= 1.2.0 (required for logging _AccessEvents_)