fix: handle trailing slash in mount paths for hostpath mapper #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
hidalgopl
reviewed
Sep 24, 2024
| @@ -25,6 +25,9 @@ const ( | |||
| func (t *translator) ensureMountPropagation(pPod *corev1.Pod) { | |||
| for i, container := range pPod.Spec.Containers { | |||
| for j, volumeMount := range container.VolumeMounts { | |||
| // handle scenarios where path ends with a / | |||
| volumeMount.MountPath = strings.TrimSuffix(volumeMount.MountPath, "/") | |||
There was a problem hiding this comment.
Could you add unit test case for it to the TestVolumeTranslation?
There was a problem hiding this comment.
I'll merge this for now, we can do a separate PR with the unit test
FabianKramm
approved these changes
Sep 24, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Sep 24, 2024
[v0.20] Merge pull request #2169 from neogopher/hpm-handle-trailingslash-mountpaths
This was referenced Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4427
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where bind mounts for hostpath mapping would not forward changes correctly when mountpath contained a trailing forward-slash