Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing in getIONEX.py #29

Open
infy-infy opened this issue Nov 15, 2019 · 0 comments
Open

Incorrect parsing in getIONEX.py #29

infy-infy opened this issue Nov 15, 2019 · 0 comments

Comments

@infy-infy
Copy link

  1. if readdata: data = np.fromstring(" -".join(line.strip().split("-")), sep=" ") * exponent
    This line doesn't parse case when all number places in value are used (there's 5 places per value in data in IONEX file) correctly. It's better to split them by 5 characters, not by space.
  2. Using just datetime.datetime in parsing data in IONEX header also is not enough: sometimes they use 24th hour of current day instead of 0 hour of next day, what leads to datetime error. So this case should be handled separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant