Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting hours with the shift key does not work #45

Open
Guiguess68210 opened this issue May 10, 2022 · 2 comments
Open

Selecting hours with the shift key does not work #45

Guiguess68210 opened this issue May 10, 2022 · 2 comments

Comments

@Guiguess68210
Copy link

Hello,

Your clock timepicker library is very convenient to use on mobile, however on my laptop I found a problem : I tried to use the shift key to select a time or duration however the key is blocked.
I searched in the library and I noticed that you have blocked the use of the shift key (line 1537 => event.shiftkey).
Would it be possible to put an option to activate it or unblock it by deleting this part of the code ?

Sincerely
Guiguess.

@loebi-ch
Copy link
Owner

Hi @Guiguess68210

What do you want to achieve by using the shift key?
You can use the arrow keys and numbers on the keyboard to select/enter the time/duration.

Best regards,
Andy

@Guiguess68210
Copy link
Author

Some computers don't have number keys, and people don't necessarily think of caps lock to select numbers. They activate the shift key each time and then select the numbers.
So to prevent them from losing their habit, it would be interesting not to block the shift key

Best regards,
Guiguess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants