Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Android] Bottom Sheet is Unable to Fully Expand After Opening and Closing TextInput #41

Closed
keith-badulis opened this issue Jun 17, 2024 · 5 comments · Fixed by #42

Comments

@keith-badulis
Copy link

Hello! I'm liking the performance of your bottom sheet so far (coming from Gorhom's, which has been sluggish on mine with more complex content). However, I'm facing this issue after opening and closing a TextInput in the bottom sheet:

screen-20240617-1333472.mp4

I'm using a FlatList inside the bottom sheet, which works well as it expands to full while scrolling down the list. After opening and closing the TextInput, the sheet cannot be extended to full anymore.

For additional context, I'm wrapping everything with a KeyboardAvoidingView with its behavior set to "height".

Thanks!

@lodev09
Copy link
Owner

lodev09 commented Jun 17, 2024

Keyboard is already handled internally. Try to remove KeyboardAvoidingView and see if that works.

@keith-badulis
Copy link
Author

keith-badulis commented Jun 17, 2024

Hello, I've removed KeyboardAvoidingView but the issue still persists. I'm also currently using Expo 51 with React Native 0.74.2.

This issue only occurs when using FlatList.

@lodev09
Copy link
Owner

lodev09 commented Jun 17, 2024

I see the issue. It has something to do with FlatList not working well with SOFT_INPUT_ADJUST_RESIZE mode for the keyboard :/

There's no general solution for now so I'm going to expose a prop to configure the input mode of the sheet.

@lodev09
Copy link
Owner

lodev09 commented Jun 17, 2024

@keith-badulis PR #42 should handle this for you. Give a test and let me know how it goes.

Thanks

@keith-badulis
Copy link
Author

Hello, thank you very much for this fix! I'll start migrating to this package. Looking forward to more features in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants