Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula generation: reduce number of initial terms #263

Open
ckrause opened this issue Jun 25, 2023 · 0 comments
Open

Formula generation: reduce number of initial terms #263

ckrause opened this issue Jun 25, 2023 · 0 comments
Labels
enhancement Improvement that is not a feature

Comments

@ckrause
Copy link
Contributor

ckrause commented Jun 25, 2023

In getNumInitialTermsNeeded() we use the number of stateful cells to estimate the number of needed initial terms. This is actually an overcount. We could reduce it by computing a dependency graph of the stateful cells and use the length of its longest path instead.

https://github.com/loda-lang/loda-cpp/blob/main/src/form/formula_gen.cpp#L194

@ckrause ckrause added the enhancement Improvement that is not a feature label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement that is not a feature
Projects
None yet
Development

No branches or pull requests

1 participant