Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show legends on charts #1651

Closed
talhajunaidd opened this issue Dec 10, 2020 · 3 comments · Fixed by #1655
Closed

Show legends on charts #1651

talhajunaidd opened this issue Dec 10, 2020 · 3 comments · Fixed by #1655

Comments

@talhajunaidd
Copy link

Is your feature request related to a problem? Please describe.

Sometimes when we need to share screenshots of the Requests per seconds we need to explain explicitly what does green and red colored lines mean,

Describe the solution you'd like

It will be handy to have legends on the charts so that is easy for the reader

Describe alternatives you've considered

Additional context

I've tried passing legend option this.chart.setOption in chart.js
but it did not show the legend.

@cyberw
Copy link
Collaborator

cyberw commented Dec 10, 2020

Sounds like a good idea. PRs welcome.

@talhajunaidd
Copy link
Author

I would love to create an MR
I've tried passing the legend option this.chart.setOption in chart.js but it did not show the legend. Could you help me out here and point to what I'm missing?

@cyberw
Copy link
Collaborator

cyberw commented Dec 10, 2020

Sorry, I dont know the UI very well..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants