-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Keycloak 26 (without keycloakify) #3266
Draft
corneliusroemer
wants to merge
4
commits into
main
Choose a base branch
from
kc26
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Bumps org.keycloak:keycloak-admin-client from 23.0.7 to 26.0.2. --- updated-dependencies: - dependency-name: org.keycloak:keycloak-admin-client dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit 057e7b0)
corneliusroemer
force-pushed
the
kc26
branch
from
November 21, 2024 22:38
445f81a
to
6729622
Compare
Maybe something about our login/cookie fixture setup for E2E is no longer permitted in kc 26:
Login doesn't seem to work (keycloak itself is fine). Website logs say this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1221
preview URL: https://kc26.loculus.org
Summary
Getting keycloak ready, now just waiting for keycloakify. One can already use as is, keycloakify is just for the looks (and the checkbox). Even registration still works!
Screenshot
Can already be used, just the login theme is missing. Everything else looks great.
Weird that E2E tests fail on this but it works in practice.That's because we're using the non-26 ready theme here, stupid me.PR Checklist