feat(integration): Add initial "integration tests" #3121
+525
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,6 +217,7 @@ def handle_helm(): | |||
|
|
|||
| if args.for_e2e or args.dev: | |||
| parameters += ["-f", HELM_CHART_DIR / "values_e2e_and_dev.yaml"] | |||
| parameters += ["--set", "auth.verifyEmail=false"] | |||
There was a problem hiding this comment.
Why don't we put that in the e2e values.yaml? Or even in the real values.yaml?
integration-tests/run.sh
Outdated
There was a problem hiding this comment.
It's called run, but it doesn't run the tests? :)
There was a problem hiding this comment.
Yes thanks - this is mostly just WIP and will probably go :)
theosanderson
force-pushed
the
integration-tests
branch
from
b1531d8
to
e8da5fe
Compare
theosanderson
force-pushed
the
integration-tests
branch
from
e8da5fe
to
4350309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided we should have tests that will ultimately test the preprocessing pipelines and ingest. I propose to call these "integration tests" just to have a new name. Unlike other website-related tests they will live in their own top level directory.
My idea for this is that we should try to see how far we can get with these tests only interacting with Loculus in ways that users would. This means primarily the website, though as we add say a CLI it would also include that. So, setting up test data etc. can all be done through the website at least until we find that that is being flaky or too slow.