-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download panel ignores accesssion filter #1629
Comments
This is not easy to implement for a large list of accessions/for a query that exceeds the limits of a GET request. At least as far as I could find out, it is not possible to open a new page (to download a file) from a POST request with JSON data. It is possible if we send the query as form-data but that is not supported by LAPIS. @corneliusroemer, @theosanderson - what do you think, how should we proceed and prioritize this issue? Should we not support the download if the user filters for a large list of accessions, or do you think that this is important and we should add support for form-data requests in LAPIS in the short term? |
Thanks for investigating this. This is a feature I believe is really quite useful. IMO if we don't support it we should probably remove the ability to enter multiple accessions entirely. I don't have a sense of how hard it would be to do in LAPIS. A potential alternative would be to have an intermediate astro route that converts the form data into JSON and calls LAPIS and streams the result from LAPIS back. |
Yeah, that sounds like a good alternative! That might be the easiest thing to do. |
We will add form data support to LAPIS: GenSpectrum/LAPIS#754 |
On this page with an active accession filter, if I download the metadata, I get all metadata instead of only the data of one sequence.
The text was updated successfully, but these errors were encountered: