Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download panel ignores accesssion filter #1629

Closed
chaoran-chen opened this issue Apr 19, 2024 · 4 comments · Fixed by #1953
Closed

Download panel ignores accesssion filter #1629

chaoran-chen opened this issue Apr 19, 2024 · 4 comments · Fixed by #1953
Assignees
Labels
bug Something isn't working website Tasks related to the web application
Milestone

Comments

@chaoran-chen
Copy link
Member

On this page with an active accession filter, if I download the metadata, I get all metadata instead of only the data of one sequence.

@chaoran-chen chaoran-chen added bug Something isn't working website Tasks related to the web application labels Apr 19, 2024
@chaoran-chen chaoran-chen added this to the MVP (public) milestone Apr 19, 2024
@chaoran-chen chaoran-chen self-assigned this Apr 19, 2024
@chaoran-chen chaoran-chen moved this to Prioritized in Planning Apr 19, 2024
@chaoran-chen
Copy link
Member Author

This is not easy to implement for a large list of accessions/for a query that exceeds the limits of a GET request. At least as far as I could find out, it is not possible to open a new page (to download a file) from a POST request with JSON data. It is possible if we send the query as form-data but that is not supported by LAPIS.

@corneliusroemer, @theosanderson - what do you think, how should we proceed and prioritize this issue? Should we not support the download if the user filters for a large list of accessions, or do you think that this is important and we should add support for form-data requests in LAPIS in the short term?

@theosanderson
Copy link
Member

Thanks for investigating this. This is a feature I believe is really quite useful. IMO if we don't support it we should probably remove the ability to enter multiple accessions entirely. I don't have a sense of how hard it would be to do in LAPIS. A potential alternative would be to have an intermediate astro route that converts the form data into JSON and calls LAPIS and streams the result from LAPIS back.

@chaoran-chen
Copy link
Member Author

Yeah, that sounds like a good alternative! That might be the easiest thing to do.

@chaoran-chen
Copy link
Member Author

chaoran-chen commented Apr 24, 2024

We will add form data support to LAPIS: GenSpectrum/LAPIS#754

@chaoran-chen chaoran-chen moved this from Prioritized to Blocked in Planning Apr 24, 2024
@theosanderson theosanderson added the blocked Issue cannot be fixed until blocked resolved label Apr 28, 2024
@chaoran-chen chaoran-chen moved this from Blocked to Prioritized in Planning Apr 30, 2024
@chaoran-chen chaoran-chen removed the blocked Issue cannot be fixed until blocked resolved label Apr 30, 2024
@chaoran-chen chaoran-chen moved this from Prioritized to In Progress in Planning May 19, 2024
@chaoran-chen chaoran-chen moved this from In Progress to In Review in Planning May 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Planning May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Tasks related to the web application
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants