Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata download: timestamps are serialized as unix integer timestamp rather than iso-string #1502

Closed
corneliusroemer opened this issue Mar 27, 2024 · 7 comments
Labels
blocked Issue cannot be fixed until blocked resolved silo/LAPIS upstream silo/LAPIS issue
Milestone

Comments

@corneliusroemer
Copy link
Contributor

From #1421:

submittedAt and released at is a unix timestamp, we should serialize it as human readable timestamp, something like 2023-01-05Z23:11:56?

This requires changes to SILO

@corneliusroemer corneliusroemer added blocked Issue cannot be fixed until blocked resolved silo/LAPIS upstream silo/LAPIS issue labels Mar 27, 2024
@corneliusroemer corneliusroemer added this to the post-MVP milestone Mar 27, 2024
@theosanderson
Copy link
Member

dupe: #838

@theosanderson
Copy link
Member

IMO we don't necessarily need to change SILO, we just need to ensure we have a readable version in addition.

@corneliusroemer
Copy link
Contributor Author

Thanks for finding the dupe! We should indeed export to metadata the normal iso-date string, like 2023-01-20 - and omit the unix timestamp IMO

@theosanderson
Copy link
Member

We use the timestamp to display the time of release on the website which was at some stage considered a desirable feature

@corneliusroemer
Copy link
Contributor Author

-Yes this issue is about metadata export to TSV, not about seq details page.

In the TSV, it would be better to have something that isn't as plain as an integer - I feel the timestamp could be committed for the metadata export but either is fine.

@theosanderson
Copy link
Member

theosanderson commented Mar 27, 2024

👍 I thought you were saying omit from SILO export

@theosanderson
Copy link
Member

I think the only agreed change we plan to make year has been carried out, as discussed in #838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue cannot be fixed until blocked resolved silo/LAPIS upstream silo/LAPIS issue
Projects
None yet
Development

No branches or pull requests

2 participants