Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rodrigodelmonte/terraform-aws-kinesis-stream
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lock8/terraform-aws-kinesis-stream
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Aug 7, 2023

  1. Copy the full SHA
    654627d View commit details
Showing with 3 additions and 5 deletions.
  1. +1 −1 README.md
  2. +2 −3 main.tf
  3. +0 −1 variables.tf
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ module "kinesis-stream" {
| kms\_key\_id | The GUID for the customer-managed KMS key to use for encryption. You can also use a Kinesis-owned master key by specifying the alias alias/aws/kinesis. | `string` | `""` | no |
| name | A name to identify the stream. This is unique to the AWS account and region the Stream is created in. | `string` | n/a | yes |
| retention\_period | Length of time data records are accessible after they are added to the stream. The maximum value of a stream's retention period is 168 hours. Minimum value is 24. Default is 24. | `number` | `24` | no |
| shard\_count | The number of shards that the stream will use | `number` | `1` | no |
| shard\_count | The number of shards that the stream will use, if you pass *null* then it will create on-demand stream | `number` | n/a | yes |
| shard\_level\_metrics | A list of shard-level CloudWatch metrics which can be enabled for the stream. | `list(string)` | `[]` | no |
| tags | A mapping of tags to assign to the resource. | `map` | n/a | yes |

5 changes: 2 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
@@ -9,9 +9,8 @@ resource "aws_kinesis_stream" "this" {
kms_key_id = var.kms_key_id
tags = var.tags

// Ignore future changes on the desired count value
lifecycle {
ignore_changes = [shard_count]
stream_mode_details {
stream_mode = var.shard_count == null ? "ON_DEMAND" : "PROVISIONED"
}

}
1 change: 0 additions & 1 deletion variables.tf
Original file line number Diff line number Diff line change
@@ -6,7 +6,6 @@ variable "name" {
variable "shard_count" {
description = "The number of shards that the stream will use"
type = number
default = 1
}

variable "retention_period" {