Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the Possibility of a MultipixelTile Type #1447

Closed
jamesmcclain opened this issue Apr 14, 2016 · 2 comments
Closed

Investigate the Possibility of a MultipixelTile Type #1447

jamesmcclain opened this issue Apr 14, 2016 · 2 comments

Comments

@jamesmcclain
Copy link
Member

jamesmcclain commented Apr 14, 2016

As part of #1429, I found that a helpful schema was to think of different configurations of stacks of layers (whether Tiles, MultibandTiles, ordered sequences of Tiles, a Tile, two MultibandTiles and another Tile, &c) as consisting of multipixels (sequences of pixels), indexed by column and row.

This branch contains some work that was done in that direction.

While the idea is unifying and brings some conceptual benefits, there are also performance implications to be sorted out.

The PR comments originally associated with #1429 are reproduced below:

In this pull request the TileFeature[T, D] type is added.

Points to Examine

  • The TileFeature[T <: CellGrid,D: ? => BundleMethods[D]] type takes two type parameters, but the merge methods (in both raster and spark assume that T <: Tile. There are no assumptions on D other than it being a member of the bundle type class.
  • There is a question of range and precision of the data D. Right now they are treated as integer entities. Double versions are possible as well, but since one of the supported types of D is Seq[Tile], there is a question of how (best) to handle the situation when the data are mixed integers and floats.
  • I found that I had to add these secondary conversions from subclasses of BundleMethods[D] to BundleMethods[D] in order to get the constraints on TileFeatureMergeMethods to be satisfied. The issue seems to be that the Scala compiler does not look more than one layer deep when trying to satisfy these constraints. If there is a better way to handle this, I am open to it.
@jamesmcclain jamesmcclain changed the title Investigate the Possibility of a MultipixelTile Idea Investigate the Possibility of a MultipixelTile Type Apr 15, 2016
@lossyrob lossyrob added this to the 1.1 milestone Oct 19, 2016
@jamesmcclain
Copy link
Member Author

Perhaps we should close this issue?

@lossyrob
Copy link
Member

That makes sense. It will still be search-able in case a similar idea comes up.

@lossyrob lossyrob removed this from the 1.1 milestone Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants