Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-clients: check if accounts are already created/funded #72

Open
chadoh opened this issue Jun 17, 2024 · 2 comments
Open

build-clients: check if accounts are already created/funded #72

chadoh opened this issue Jun 17, 2024 · 2 comments
Assignees

Comments

@chadoh
Copy link
Contributor

chadoh commented Jun 17, 2024

Follow-up to #42

In the "creating keys for _____" step, we want to speed things up and keep them more predictable by skipping key-generation and account-funding if the account already exists.

We should maybe ship this as an upstream update in soroban keys generate, which is what is used by build_clients.rs. I've created an issue there, to see how everyone feels about this logic being included in the main CLI:

@chadoh chadoh added this to Aha Jun 18, 2024
@chadoh chadoh moved this to To do in Aha Jun 18, 2024
@BlaineHeffron BlaineHeffron moved this from To do to In Progress in Aha Jul 16, 2024
@BlaineHeffron BlaineHeffron self-assigned this Jul 16, 2024
@BlaineHeffron
Copy link
Contributor

BlaineHeffron commented Jul 23, 2024

Currently a workaround is in place but once stellar/stellar-cli#1380 and stellar/stellar-cli#1389 are merged into an updated release, we can remove it.

@willemneal
Copy link
Collaborator

@chadoh What is the status here?

@willemneal willemneal removed the status in Aha Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants