Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes for summary callback changes #1788

Merged
merged 6 commits into from
Jan 12, 2021
Merged

Misc fixes for summary callback changes #1788

merged 6 commits into from
Jan 12, 2021

Conversation

na--
Copy link
Member

@na-- na-- commented Jan 11, 2021

This fixes #1316 and contains the prerequisite changes (and a few minor unrelated ones) for #1768. I've taken the extraneous changes from that PR, split them apart in sensible commits, and added some more tests. Hopefully, the only thing that remains in #1768 would be the actual handleSummary() changes, though I may have a few other minor commits to make here before I push the final version of the other PR (likely tomorrow).

@na-- na-- requested review from mstoykov and imiric January 11, 2021 08:22
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #1788 (10ac39f) into master (ccffbca) will increase coverage by 0.17%.
The diff coverage is 79.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
+ Coverage   71.43%   71.60%   +0.17%     
==========================================
  Files         178      178              
  Lines       13777    13789      +12     
==========================================
+ Hits         9841     9874      +33     
+ Misses       3323     3303      -20     
+ Partials      613      612       -1     
Flag Coverage Δ
ubuntu 71.54% <79.71%> (+0.13%) ⬆️
windows 70.11% <79.71%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/config.go 88.18% <ø> (+3.26%) ⬆️
cmd/run.go 7.39% <0.00%> (+0.18%) ⬆️
lib/runtime_options.go 100.00% <ø> (ø)
stats/cloud/cloud_easyjson.go 33.97% <0.00%> (ø)
ui/summary.go 89.35% <ø> (ø)
stats/stats.go 77.11% <50.00%> (-1.13%) ⬇️
cmd/runtime_options.go 87.69% <93.33%> (+6.29%) ⬆️
core/engine.go 93.03% <100.00%> (+2.08%) ⬆️
js/bundle.go 90.54% <100.00%> (ø)
lib/models.go 94.11% <100.00%> (+0.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccffbca...10ac39f. Read the comment docs.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor point that we might be degrading the marshalling performance, but someone will have to run/write a benchmark that uses it to see how much it is degrading if at all

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@na-- na-- merged commit def5ac7 into master Jan 12, 2021
@na-- na-- deleted the misc-fixes-for-summary branch January 12, 2021 13:21
@na-- na-- added this to the v0.30.0 milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups in the end-of-test summary are unordered
4 participants