Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/crypto and golang.org/x/net #1734

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

na--
Copy link
Member

@na-- na-- commented Nov 20, 2020

Turns out we were using very old versions for these libraries and we didn't notice partially because of the replace directives. These are now updated to the latest commits on their respective release-branch.go1.15 branches...

@na-- na-- added this to the v0.30.0 milestone Nov 20, 2020
@na-- na-- requested review from mstoykov and imiric November 20, 2020 15:41
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞 😬

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #1734 (0ca1f12) into master (f8fcabf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1734   +/-   ##
=======================================
  Coverage   71.50%   71.50%           
=======================================
  Files         178      178           
  Lines       13727    13727           
=======================================
  Hits         9816     9816           
  Misses       3299     3299           
  Partials      612      612           
Flag Coverage Δ
ubuntu 71.45% <ø> (-0.02%) ⬇️
windows 70.08% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/executor/vu_handle.go 93.33% <0.00%> (-1.91%) ⬇️
stats/cloud/collector.go 79.81% <0.00%> (-0.64%) ⬇️
core/engine.go 92.96% <0.00%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fcabf...0ca1f12. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants