Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade goja #1707

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Upgrade goja #1707

merged 1 commit into from
Nov 4, 2020

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 4, 2020

fixes #1126

@mstoykov mstoykov requested review from na-- and imiric November 4, 2020 09:46
@mstoykov mstoykov added this to the v0.29.0 milestone Nov 4, 2020
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #1707 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   71.42%   71.42%   -0.01%     
==========================================
  Files         176      176              
  Lines       13681    13679       -2     
==========================================
- Hits         9772     9770       -2     
  Misses       3298     3298              
  Partials      611      611              
Flag Coverage Δ
ubuntu 71.37% <ø> (-0.01%) ⬇️
windows 69.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stats/cloud/collector.go 79.81% <0.00%> (-0.64%) ⬇️
cmd/cloud.go 4.86% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51095a...ecbb172. Read the comment docs.

@mstoykov mstoykov merged commit b4a66b1 into master Nov 4, 2020
@mstoykov mstoykov deleted the updateGOja branch November 4, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading certain minified JS libraries
4 participants