Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for cloud to actually stop the test on first '^C' #1705

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 2, 2020

Also:

  • move the signal handling as far up as possible
  • stop the test in goroutine so if that takes a while a second ^C will
    again stop the test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Also:
- move the signal handling as far up as possible
- stop the test in goroutine so if that takes a while a second ^C will
  again stop the test
@mstoykov mstoykov requested review from na-- and imiric November 2, 2020 15:11
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the typo, also please close #1704

cmd/cloud.go Outdated Show resolved Hide resolved
Co-authored-by: na-- <n@andreev.sh>
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstoykov mstoykov added this to the v0.29.0 milestone Nov 4, 2020
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but LGTM.

@mstoykov mstoykov merged commit aeb4c86 into master Nov 4, 2020
@mstoykov mstoykov deleted the fix/cloudWaitForTestToFinish branch November 4, 2020 09:40
salem84 pushed a commit to salem84/k6 that referenced this pull request Nov 5, 2020
Also:
- move the signal handling as far up as possible
- stop the test in goroutine so if that takes a while a second ^C will
  again stop the test


Co-authored-by: na-- <n@andreev.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants