-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immediately shutdown k6 cloud
on second sig-c signal
#1647
Immediately shutdown k6 cloud
on second sig-c signal
#1647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
- Coverage 72.16% 72.11% -0.06%
==========================================
Files 166 166
Lines 12787 12794 +7
==========================================
- Hits 9228 9226 -2
- Misses 3009 3018 +9
Partials 550 550
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! At a quick glance, it looks very good, but I'd like to test the new code as well before giving it the final 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it as well and everything seems fine, thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the race condition reported in #1647 (comment)
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
+ Coverage 72.16% 72.33% +0.17%
==========================================
Files 166 176 +10
Lines 12787 13539 +752
==========================================
+ Hits 9228 9794 +566
- Misses 3009 3132 +123
- Partials 550 613 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Mihail Stoykov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though the old shouldExitLoop
behavior would have been better than a direct break
of the loop, since now we won't update the progress (testProgress = newTestProgress
), but we can fix that later in another PR.
Trap signal and handle second sig-c to shutdown
k6 cloud
immediatelyCloses #1530