bug/1560 tlsCipherSuites and tlsVersion marshaling

[berndhartzer]

Closes #1560

[berndhartzer]

The linter picks up many errors, most of which are for files I haven't changed. One error that is relevant PR is this one:

lib/options.go:101:1                        golint            exported method `TLSCipherSuites.MarshalJSON` should have comment or be unexported

But this line is similar to others in the file (e.g. line 49: func (v TLSVersion) MarshalJSON() ([]byte, error) {) so I'm not sure how to go about resolving that error (or the other errors), let me know and I can amend the PR!

[mstoykov]

Hi @berndhartzer, thanks for the PR !!! 🎉

We have fixed the lint to not get wrong files (or at least for your case) so please just rebase on top of the current master and force-push in order to get the fix

[codecov-commenter]

Codecov Report

Merging #1603 into master will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
+ Coverage   74.82%   74.83%   +0.01%     
==========================================
  Files         164      164              
  Lines       14035    14043       +8     
==========================================
+ Hits        10501    10509       +8     
+ Misses       3002     3001       -1     
- Partials      532      533       +1     

Impacted Files	Coverage Δ
lib/options.go	87.19% <75.00%> (-0.51%)	⬇️
lib/testutils/minirunner/minirunner.go	78.57% <0.00%> (-3.58%)	⬇️
lib/executor/vu_handle.go	95.49% <0.00%> (+1.80%)	⬆️
lib/executors.go	94.11% <0.00%> (+1.96%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68a4eb...9160ea8. Read the comment docs.

[berndhartzer]

Hi @berndhartzer, thanks for the PR !!! 🎉

We have fixed the lint to not get wrong files (or at least for your case) so please just rebase on top of the current master and force-push in order to get the fix

Thanks @mstoykov I've fixed it now 🙂

[imiric]

LGTM, just a nitpick and a comment.

[imiric]

FWIW I think we could fix the envconfig issue with a custom decoder and keep the K6_TLS_VERSION env var, but since it's not documented in the k6 docs, and making it work is tricky in general because of #883, I'm OK with ignoring it.

[na--]

We can't keep delaying the envconfig removal, so lets ignore this for now and fix it properly everywhere soon.

[imiric]

Thanks for your work!