-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gzip in csv output format #1566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
+ Coverage 77.11% 77.12% +0.01%
==========================================
Files 162 162
Lines 13192 13204 +12
==========================================
+ Hits 10173 10184 +11
- Misses 2499 2500 +1
Partials 520 520
Continue to review full report at Codecov.
|
Added document for CSV format here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your work @thejasbabu!
This looks good besides the two minor comments. We're aiming for this to be part of v0.28.0 👍
Refactor: - Add closeFn for CSV collector - Made writeToFile protected Signed-off-by: thejas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this and the additional test!
Fixes: #1550
Refactor:
Tested this by using the following script
test.js
and running